Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiscreteVariable: reset colors when new values added #1807

Merged
merged 1 commit into from Dec 9, 2016

Conversation

Projects
None yet
4 participants
@kernc
Copy link
Member

commented Dec 9, 2016

Issue

Fixes biolab/orange3-prototypes#55 (comment) .. biolab/orange3-prototypes#55 (comment)

Description of changes

Resets _colors when new DiscreteVariable.values are added.

Includes
  • Code changes
  • Tests
  • Documentation

@kernc kernc force-pushed the kernc:discretevar/ncolors--nvalues branch from 5bcc1fd to dda48df Dec 9, 2016

@codecov-io

This comment has been minimized.

Copy link

commented Dec 9, 2016

Current coverage is 89.03% (diff: 100%)

Merging #1807 into master will increase coverage by <.01%

@@             master      #1807   diff @@
==========================================
  Files            85         85          
  Lines          9019       9021     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           8030       8032     +2   
  Misses          989        989          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update eedd0ef...dda48df

@janezd janezd merged commit 5fabe61 into biolab:master Dec 9, 2016

5 checks passed

codecov/patch 100% of diff hit (target 95.00%)
Details
codecov/project 89.03% (+<.01%) compared to eedd0ef
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

astaric added a commit to astaric/orange3 that referenced this pull request Jan 4, 2017

Merge pull request biolab#1807 from kernc/discretevar/ncolors--nvalues
DiscreteVariable: reset colors when new values added

astaric added a commit to astaric/orange3 that referenced this pull request Jan 4, 2017

Merge pull request biolab#1807 from kernc/discretevar/ncolors--nvalues
DiscreteVariable: reset colors when new values added

astaric added a commit to astaric/orange3 that referenced this pull request Jan 4, 2017

Merge pull request biolab#1807 from kernc/discretevar/ncolors--nvalues
DiscreteVariable: reset colors when new values added

@astaric astaric modified the milestone: 3.3.10 Jan 4, 2017

astaric added a commit to astaric/orange3 that referenced this pull request Jan 6, 2017

Merge pull request biolab#1807 from kernc/discretevar/ncolors--nvalues
DiscreteVariable: reset colors when new values added
(cherry picked from commit 5fabe61)

astaric added a commit to astaric/orange3 that referenced this pull request Jan 10, 2017

Merge pull request biolab#1807 from kernc/discretevar/ncolors--nvalues
DiscreteVariable: reset colors when new values added
(cherry picked from commit 5fabe61)

astaric added a commit to astaric/orange3 that referenced this pull request Jan 11, 2017

Merge pull request biolab#1807 from kernc/discretevar/ncolors--nvalues
DiscreteVariable: reset colors when new values added
(cherry picked from commit 5fabe61)

astaric added a commit to astaric/orange3 that referenced this pull request Jan 13, 2017

Merge pull request biolab#1807 from kernc/discretevar/ncolors--nvalues
DiscreteVariable: reset colors when new values added
(cherry picked from commit 5fabe61)

astaric added a commit to astaric/orange3 that referenced this pull request Jan 18, 2017

Merge pull request biolab#1807 from kernc/discretevar/ncolors--nvalues
DiscreteVariable: reset colors when new values added
(cherry picked from commit 5fabe61)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.