Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix copy to clipboard in "Data Table" widget #1808

Merged
merged 2 commits into from Dec 9, 2016

Conversation

Projects
None yet
4 participants
@ales-erjavec
Copy link
Contributor

commented Dec 9, 2016

Issue

Copy to clipboard shortcut (Ctrl-C) did not work since 55d31c1 due to ambiguous shortcut overload.

It also raised a TypeError when running with PyQt5.

Description of changes
Includes
  • Code changes
  • Tests
  • Documentation

ales-erjavec added some commits Dec 9, 2016

owtable: Fix copy selection to clipoard
Did not work since 55d31c1
due to ambiguous shortcut overload
owtable: Fix an TypeError when using PyQt5
`PyQt5.QtCore.QByteArray` raises an TypeError if called with
a `str.
@codecov-io

This comment has been minimized.

Copy link

commented Dec 9, 2016

Current coverage is 89.03% (diff: 100%)

Merging #1808 into master will not change coverage

@@             master      #1808   diff @@
==========================================
  Files            85         85          
  Lines          9019       9019          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           8030       8030          
  Misses          989        989          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update eedd0ef...cc58931

@kernc kernc merged commit c4755ab into biolab:master Dec 9, 2016

5 checks passed

codecov/patch Coverage not affected when comparing eedd0ef...cc58931
Details
codecov/project 89.03% (+0.00%) compared to eedd0ef
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

astaric added a commit to astaric/orange3 that referenced this pull request Jan 4, 2017

Merge pull request biolab#1808 from ales-erjavec/fixes/table-clipboar…
…d-copy

[FIX] Fix copy to clipboard in "Data Table" widget

astaric added a commit to astaric/orange3 that referenced this pull request Jan 4, 2017

Merge pull request biolab#1808 from ales-erjavec/fixes/table-clipboar…
…d-copy

[FIX] Fix copy to clipboard in "Data Table" widget

astaric added a commit to astaric/orange3 that referenced this pull request Jan 4, 2017

Merge pull request biolab#1808 from ales-erjavec/fixes/table-clipboar…
…d-copy

[FIX] Fix copy to clipboard in "Data Table" widget

@astaric astaric modified the milestone: 3.3.10 Jan 4, 2017

astaric added a commit to astaric/orange3 that referenced this pull request Jan 6, 2017

Merge pull request biolab#1808 from ales-erjavec/fixes/table-clipboar…
…d-copy

[FIX] Fix copy to clipboard in "Data Table" widget
(cherry picked from commit c4755ab)

astaric added a commit to astaric/orange3 that referenced this pull request Jan 10, 2017

Merge pull request biolab#1808 from ales-erjavec/fixes/table-clipboar…
…d-copy

[FIX] Fix copy to clipboard in "Data Table" widget
(cherry picked from commit c4755ab)

astaric added a commit to astaric/orange3 that referenced this pull request Jan 11, 2017

Merge pull request biolab#1808 from ales-erjavec/fixes/table-clipboar…
…d-copy

[FIX] Fix copy to clipboard in "Data Table" widget
(cherry picked from commit c4755ab)

astaric added a commit to astaric/orange3 that referenced this pull request Jan 13, 2017

Merge pull request biolab#1808 from ales-erjavec/fixes/table-clipboar…
…d-copy

[FIX] Fix copy to clipboard in "Data Table" widget
(cherry picked from commit c4755ab)

astaric added a commit to astaric/orange3 that referenced this pull request Jan 18, 2017

Merge pull request biolab#1808 from ales-erjavec/fixes/table-clipboar…
…d-copy

[FIX] Fix copy to clipboard in "Data Table" widget
(cherry picked from commit c4755ab)

@ales-erjavec ales-erjavec deleted the ales-erjavec:fixes/table-clipboard-copy branch Jan 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.