Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upOrange.data: Clean up the namespace #1813
Conversation
lanzagar
force-pushed the
lanzagar:fixdatanamespace
branch
from
a1d97b8
to
d692ae6
Dec 9, 2016
kernc
reviewed
Dec 9, 2016
| @@ -29,6 +29,9 @@ | |||
| from Orange.util import Registry, flatten, namegen | |||
|
|
|||
|
|
|||
| __all__ = ["Flags"] | |||
This comment has been minimized.
This comment has been minimized.
kernc
Dec 9, 2016
Member
I don't think that's ok. The module defines a lot more "public" stuff than just Flags. Perhaps rather make import * in Orange.data.__init__.py explicit?
This comment has been minimized.
This comment has been minimized.
astaric
Dec 10, 2016
Member
FileFormat might be considered public as well, as someone might use it to define their own readers, but what else? Reader implementations are not supposed to be used directly, they are accessible through FileReader.get_reader.
This comment has been minimized.
This comment has been minimized.
lanzagar
Dec 12, 2016
Author
Contributor
Added FileFormat. As said, the individual readers are really just current implementations that should not be used directly elsewhere, so I don't think they belong in __all__. And they can be imported from data.io if needed (for exceptional cases only).
This comment has been minimized.
This comment has been minimized.
lanzagar
force-pushed the
lanzagar:fixdatanamespace
branch
from
d692ae6
to
c7d5d20
Dec 12, 2016
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Dec 12, 2016
•
Current coverage is 89.05% (diff: 100%)@@ master #1813 diff @@
==========================================
Files 85 85
Lines 9029 9030 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 8041 8042 +1
Misses 988 988
Partials 0 0
|
astaric
reviewed
Dec 12, 2016
| @@ -11,7 +11,7 @@ | |||
| ) | |||
| from AnyQt.QtGui import QIcon, QKeySequence, QDesktopServices | |||
|
|
|||
| from Orange.data import FileFormat | |||
lanzagar commentedDec 9, 2016
•
edited
Issue
Orange.data namespace included a lot of junk.
Description of changes
Define
__all__in data.io.Includes