Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebviewWidget updates #1816

Merged
merged 5 commits into from Jan 3, 2017

Conversation

Projects
None yet
3 participants
@kernc
Copy link
Member

commented Dec 12, 2016

Issue

Various WebviewWidget updates. See commit messages.

Includes
  • Code changes
  • Tests
  • Documentation

@kernc kernc referenced this pull request Dec 12, 2016

Merged

[ENH] Map widget #1735

2 of 3 tasks complete

kernc added a commit to kernc/orange3-educational that referenced this pull request Dec 12, 2016

JS widgets: don't bridge via QWidget but via thin QObject instead
Refs: "WebView/WebEngine: don't permit exposing QWidgets"
      biolab/orange3#1816
@kernc

This comment has been minimized.

Copy link
Member Author

commented Dec 12, 2016

@kernc kernc referenced this pull request Dec 12, 2016

Merged

Small changes here and there #1799

1 of 3 tasks complete

@kernc kernc force-pushed the kernc:webview branch from 343c817 to 50e9d15 Dec 12, 2016

@codecov-io

This comment has been minimized.

Copy link

commented Dec 12, 2016

Current coverage is 89.19% (diff: 100%)

Merging #1816 into master will decrease coverage by 0.01%

@@             master      #1816   diff @@
==========================================
  Files            86         86          
  Lines          9077       9077          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           8097       8096     -1   
- Misses          980        981     +1   
  Partials          0          0          

Sunburst

Powered by Codecov. Last update e83e256...05eb059

kernc added a commit to kernc/orange3-educational that referenced this pull request Dec 21, 2016

JS widgets: don't bridge via QWidget but via thin QObject instead
Refs: "WebView/WebEngine: don't permit exposing QWidgets"
      biolab/orange3#1816

kernc added some commits Nov 30, 2016

WebView/WebEngine: warn on exposing QWidgets
Using thin QObjects instead of QWidgets prevents console warnings like:

    Property 'enabled' of object 'Highcharts' has no notify signal
    and is not constant, value updates in HTML will be broken!

Likely enforces a cleaner interface and code flow too.

@kernc kernc force-pushed the kernc:webview branch from 50e9d15 to cbe317a Jan 3, 2017

kernc added a commit to kernc/orange3-educational that referenced this pull request Jan 3, 2017

JS widgets: don't bridge via QWidget but via thin QObject instead
Refs: "WebView/WebEngine: don't permit exposing QWidgets"
      biolab/orange3#1816

kernc added a commit to kernc/orange3-educational that referenced this pull request Jan 3, 2017

JS widgets: don't bridge via QWidget but via thin QObject instead
Refs: "WebView/WebEngine: don't permit exposing QWidgets"
      biolab/orange3#1816

@kernc kernc force-pushed the kernc:webview branch from be4ef17 to 05eb059 Jan 3, 2017

@kernc kernc changed the title WebviewWidget updates [WIP] WebviewWidget updates Jan 3, 2017

@kernc kernc force-pushed the kernc:webview branch from 05eb059 to cbe317a Jan 3, 2017

@kernc kernc changed the title [WIP] WebviewWidget updates WebviewWidget updates Jan 3, 2017

@lanzagar lanzagar merged commit 47d98bf into biolab:master Jan 3, 2017

4 of 5 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
codecov/patch Coverage not affected when comparing 3ca9708...cbe317a
Details
codecov/project 89.20% (+0.00%) compared to 3ca9708
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.