Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upitemmodels.VariableListModel drag-and-drop updates #1843
Conversation
kernc
assigned
astaric and
ales-erjavec
Dec 29, 2016
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Dec 29, 2016
•
Current coverage is 89.20% (diff: 100%)@@ master #1843 diff @@
==========================================
Files 86 86
Lines 9077 9077
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 8097 8097
Misses 980 980
Partials 0 0
|
This comment has been minimized.
This comment has been minimized.
|
This breaks Corpus completely. |
kernc
added a commit
to kernc/orange3-text
that referenced
this pull request
Dec 29, 2016
kernc
force-pushed the
kernc:VarListModel_dnd
branch
from
468096d
to
e7cf8a6
Jan 2, 2017
This comment has been minimized.
This comment has been minimized.
|
Thanks. Shouldn't break Load Corpus anymore. |
kernc
added a commit
to kernc/orange3-text
that referenced
this pull request
Jan 3, 2017
lanzagar
merged commit f0e4ea3
into
biolab:master
Jan 3, 2017
astaric
added this to the 3.3.10 milestone
Jan 6, 2017
astaric
added a commit
to astaric/orange3
that referenced
this pull request
Jan 6, 2017
astaric
added a commit
to astaric/orange3
that referenced
this pull request
Jan 10, 2017
astaric
added a commit
to astaric/orange3
that referenced
this pull request
Jan 11, 2017
astaric
added a commit
to astaric/orange3
that referenced
this pull request
Jan 13, 2017
astaric
added a commit
to astaric/orange3
that referenced
this pull request
Jan 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kernc commentedDec 29, 2016
Issue
VariableListModeldrag and drop didn't work out of the box.Description of changes
Make drag and drop work out of the box. Remove redundant duplicate implementations.
Expected by biolab/orange3-prototypes#57.
Includes