Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] OWParallelCoordinates: Plotly-based #2327

Closed
wants to merge 8 commits into from

Conversation

kernc
Copy link
Contributor

@kernc kernc commented May 19, 2017

Issue

Fixes #2310

Description of changes

Remove defunct parallel coordinates widget; add Plotly JS graphing library; use it for parallel coordinates widget.

Includes
  • Code changes
  • Tests
  • Documentation

screenshot - 05192017 - 06 54 01 pm

@kernc kernc force-pushed the plotly-parallel-coords branch 3 times, most recently from c9b101b to f483e78 Compare May 22, 2017 15:19
@kernc kernc changed the title [ENH] OWParallelCoordinates: Plotly-based [WIP] [ENH] OWParallelCoordinates: Plotly-based May 22, 2017
@codecov-io
Copy link

codecov-io commented May 22, 2017

Codecov Report

Merging #2327 into master will increase coverage by 4.28%.
The diff coverage is 35.53%.

@@            Coverage Diff             @@
##           master    #2327      +/-   ##
==========================================
+ Coverage   76.06%   80.35%   +4.28%     
==========================================
  Files         338      327      -11     
  Lines       59675    56464    -3211     
==========================================
- Hits        45391    45370      -21     
+ Misses      14284    11094    -3190

@kernc kernc changed the title [WIP] [ENH] OWParallelCoordinates: Plotly-based [RFC] [ENH] OWParallelCoordinates: Plotly-based May 23, 2017
@kernc kernc requested a review from astaric June 2, 2017 12:24
@astaric
Copy link
Member

astaric commented Jun 26, 2017

I have played around with the widget. It behaves strangely.

  • When I click on an attribute in the list, selection keeps changing as I move the mouse around (as if it did not register the mouse-up event).
  • The color combo also sometimes selects an item that is different from the one I clicked.
  • When I add a new Parallel Coordinates widget to the workflow, connect it to data and open it, it performs 1-2 resizes before the plot changes to correct size.
  • I haven't found a way to remove the selection.
  • If I click on Optimize Selected Dimension and the plot is displaying more than 9 variables, nothing happens.

I have stopped at this point :)

@kernc kernc changed the title [RFC] [ENH] OWParallelCoordinates: Plotly-based [ENH] OWParallelCoordinates: Plotly-based Aug 25, 2017
@kernc kernc added this to the 3.7 milestone Oct 20, 2017
@astaric astaric removed this from the 3.7 milestone Oct 23, 2017
@astaric
Copy link
Member

astaric commented Oct 23, 2017

While I would really like to see this merged, It will not make it to the 3.7 release.

@BlazZupan, @janezd, could you take a look and comment on this new widget? If major changes are required, I would rather have it included in prototypes first and then promoted to the core when ready.

@kernc
Copy link
Contributor Author

kernc commented Oct 23, 2017

Was worth a try. 😄

@kernc
Copy link
Contributor Author

kernc commented Nov 9, 2017

For the time being, obsoleted by biolab/orange3-prototypes#99.

@kernc kernc closed this Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants