New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead orangeqt code; add gui.listView multiselection handling #2761

Merged
merged 5 commits into from Dec 8, 2017

Conversation

Projects
None yet
4 participants
@kernc
Member

kernc commented Nov 9, 2017

Description of changes

Some destructive changes split from #2327 and some other changes required by biolab/orange3-prototypes#99.

Includes
  • Code changes
  • Tests
  • Documentation

@kernc kernc referenced this pull request Nov 9, 2017

Merged

Add Plotly-based OWParallelCoordinates #99

1 of 3 tasks complete
@codecov-io

This comment has been minimized.

codecov-io commented Nov 10, 2017

Codecov Report

Merging #2761 into master will increase coverage by 4.53%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2761      +/-   ##
==========================================
+ Coverage    76.2%   80.74%   +4.53%     
==========================================
  Files         337      324      -13     
  Lines       59665    56227    -3438     
==========================================
- Hits        45469    45400      -69     
+ Misses      14196    10827    -3369
@astaric

This comment has been minimized.

Member

astaric commented Nov 16, 2017

Hooray for removals.

@janezd, could you check the changes to Call[Back|Front]ListView?

@janezd

janezd approved these changes Nov 17, 2017

I think it's better to select all items at once, which emits fewer signals -- and also simplifies the code. I also added some tests. See c30d658.

Hooray for removals, too.

@janezd

This comment has been minimized.

Contributor

janezd commented Nov 17, 2017

Pylint results
=================================================================
Number of issues on parent commit: 1188
Number of issues on the pull request: 30 (-1158)

I suppose this must be a record.

@kernc kernc modified the milestones: 3.9, 3.8 Nov 30, 2017

kernc added a commit to biolab/monroe-anal that referenced this pull request Dec 1, 2017

Add OWSignificantGroups widget
Depends on gui.listView mod from biolab/orange3#2761

@kernc kernc modified the milestones: 3.8, 3.9 Dec 4, 2017

kernc and others added some commits May 12, 2017

WebEngineView: delay showing the widget a bit
Reduce the severity of initial plot resizing?

@janezd janezd merged commit 7e6f9e5 into biolab:master Dec 8, 2017

5 checks passed

codecov/patch 100% of diff hit (target 95%)
Details
codecov/project 80.74% (+4.53%) compared to 5294673
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment