Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Tests: add support for multi-database tests #3515

Merged
merged 14 commits into from Feb 22, 2019

Conversation

Projects
None yet
2 participants
@robertcv
Copy link
Collaborator

commented Jan 4, 2019

Issue

Orange currently only supports testing for PostgresSQL although Microsoft SQL Server is also supported by Travis (#2839).

Description of changes

Extend testing so that one test can be run on multiple databases. Add testing for Microsoft SQL Server to Travis and AppVeyor.

Includes
  • Code changes
  • Tests
  • Documentation
@codecov

This comment has been minimized.

Copy link

commented Jan 7, 2019

Codecov Report

Merging #3515 into master will increase coverage by 0.11%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3515      +/-   ##
==========================================
+ Coverage   83.56%   83.67%   +0.11%     
==========================================
  Files         368      368              
  Lines       65777    65777              
==========================================
+ Hits        54964    55039      +75     
+ Misses      10813    10738      -75
@codecov

This comment has been minimized.

Copy link

commented Jan 7, 2019

Codecov Report

Merging #3515 into master will increase coverage by 0.15%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3515      +/-   ##
==========================================
+ Coverage   84.07%   84.22%   +0.15%     
==========================================
  Files         370      370              
  Lines       67268    67430     +162     
==========================================
+ Hits        56554    56796     +242     
+ Misses      10714    10634      -80

@robertcv robertcv force-pushed the robertcv:enh/multiple_databasees branch from 18fd9e5 to bffa270 Jan 7, 2019

@robertcv robertcv force-pushed the robertcv:enh/multiple_databasees branch from bffa270 to c1ca4ba Jan 18, 2019

@robertcv robertcv force-pushed the robertcv:enh/multiple_databasees branch from f65b706 to 5ff7ff8 Feb 5, 2019

@robertcv robertcv force-pushed the robertcv:enh/multiple_databasees branch from 5ff7ff8 to 228f730 Feb 5, 2019

@robertcv robertcv force-pushed the robertcv:enh/multiple_databasees branch from 228f730 to 038794c Feb 5, 2019

@robertcv robertcv changed the title [RFC][WIP] Tests: add support for multi-database tests [RFC] Tests: add support for multi-database tests Feb 6, 2019

@robertcv robertcv force-pushed the robertcv:enh/multiple_databasees branch from 25aea3d to d974b76 Feb 22, 2019

@lanzagar lanzagar changed the title [RFC] Tests: add support for multi-database tests [MNT] Tests: add support for multi-database tests Feb 22, 2019

@lanzagar lanzagar merged commit 305cad5 into biolab:master Feb 22, 2019

5 checks passed

codecov/patch 100% of diff hit (target 95%)
Details
codecov/project 84.22% (+0.15%) compared to a05809c
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.