Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate openTSNE version to >=0.3 #3552
Conversation
pavlin-policar
force-pushed the
pavlin-policar:update-tsne
branch
from
0079b03
to
7b2eccd
Jan 27, 2019
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Jan 27, 2019
Codecov Report
@@ Coverage Diff @@
## master #3552 +/- ##
==========================================
- Coverage 83.96% 83.95% -0.01%
==========================================
Files 370 370
Lines 66876 66876
==========================================
- Hits 56152 56148 -4
- Misses 10724 10728 +4 |
This comment has been minimized.
This comment has been minimized.
|
Just a reminder, that the requirement needs to be changed in the following repositories too: (not a blocker for merging here) |
lanzagar
merged commit ec0ac1e
into
biolab:master
Feb 1, 2019
5 checks passed
codecov/patch
100% of diff hit (target 95%)
Details
codecov/project
Absolute coverage decreased by -<.01% but relative coverage increased by +16.03% compared to c2735dd
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
license/cla
Contributor License Agreement is signed.
Details
pavlin-policar
deleted the
pavlin-policar:update-tsne
branch
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
pavlin-policar commentedJan 25, 2019
Issue
Due to some breaking API changes in my t-SNE implementation, I had fixed the version to 0.2.13. There are likely not going to be any more API changes, so this shouldn't be an issue anymore.
Description of changes
fastTSNE has been renamed to openTSNE in the meantime. Also, I've fixed a bug here and there from v0.2.13. I had also changed the way openTSNE.initialization.random was called, so I changed this here.
Includes