Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openTSNE version to >=0.3 #3552

Merged
merged 1 commit into from Feb 1, 2019

Conversation

Projects
None yet
2 participants
@pavlin-policar
Copy link
Collaborator

commented Jan 25, 2019

Issue

Due to some breaking API changes in my t-SNE implementation, I had fixed the version to 0.2.13. There are likely not going to be any more API changes, so this shouldn't be an issue anymore.

Description of changes

fastTSNE has been renamed to openTSNE in the meantime. Also, I've fixed a bug here and there from v0.2.13. I had also changed the way openTSNE.initialization.random was called, so I changed this here.

Includes
  • Code changes
  • Tests
  • Documentation

@pavlin-policar pavlin-policar force-pushed the pavlin-policar:update-tsne branch from 0079b03 to 7b2eccd Jan 27, 2019

@codecov

This comment has been minimized.

Copy link

commented Jan 27, 2019

Codecov Report

Merging #3552 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3552      +/-   ##
==========================================
- Coverage   83.96%   83.95%   -0.01%     
==========================================
  Files         370      370              
  Lines       66876    66876              
==========================================
- Hits        56152    56148       -4     
- Misses      10724    10728       +4
@lanzagar

This comment has been minimized.

Copy link
Contributor

commented Feb 1, 2019

Just a reminder, that the requirement needs to be changed in the following repositories too:
https://github.com/conda-forge/orange3-feedstock
https://github.com/ales-erjavec/orange3-installers

(not a blocker for merging here)

@lanzagar lanzagar merged commit ec0ac1e into biolab:master Feb 1, 2019

5 checks passed

codecov/patch 100% of diff hit (target 95%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +16.03% compared to c2735dd
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@pavlin-policar pavlin-policar deleted the pavlin-policar:update-tsne branch Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.