Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upData sampler: Allow selecting 100% of data, shuffle it #3727
Conversation
This comment has been minimized.
This comment has been minimized.
|
Removed requirement 4 from the comment, as I do not remember anymore what the intended use case was. |
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Apr 5, 2019
Codecov Report
@@ Coverage Diff @@
## master #3727 +/- ##
==========================================
+ Coverage 84.53% 84.54% +<.01%
==========================================
Files 373 373
Lines 68472 68490 +18
==========================================
+ Hits 57886 57902 +16
- Misses 10586 10588 +2 |
janezd
assigned
thocevar
Apr 12, 2019
thocevar
merged commit 80e4080
into
biolab:master
Apr 12, 2019
5 checks passed
codecov/patch
100% of diff hit (target 95%)
Details
codecov/project
84.54% (+<.01%) compared to 08da18a
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
license/cla
Contributor License Agreement is signed.
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
janezd commentedApr 5, 2019
Issue
Closes #2035.
Description of changes
#2035 required:
I've done them all, but I didn't have a good use case in 4. @ajdapretnar, in an already agitated state because of certain issues around #3722, told me in no uncertain terms to remove it. I'm married for 17 years, so I know better than to complain. On the contrary, I must say that I didn't like that text either, so I was very happy to remove it.
Documentation still explains that choosing the entire data set shuffles it, which, I must say, should suffice.
(Joke aside, it indeed does.)
Includes