Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upVariable: Remove attribute base_value #3728
Conversation
janezd
force-pushed the
janezd:remove-base-value
branch
from
545ee64
to
01a7bfa
Apr 5, 2019
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Apr 5, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #3728 +/- ##
==========================================
+ Coverage 84.81% 84.88% +0.07%
==========================================
Files 374 374
Lines 68767 68829 +62
==========================================
+ Hits 58323 58424 +101
+ Misses 10444 10405 -39 |
janezd
force-pushed the
janezd:remove-base-value
branch
from
1eefc3c
to
ace36eb
Apr 5, 2019
janezd
assigned
lanzagar
Apr 12, 2019
janezd
force-pushed the
janezd:remove-base-value
branch
from
ace36eb
to
3109743
Apr 12, 2019
This comment has been minimized.
This comment has been minimized.
|
Besides the 4 failing tests, I have found just one other use of base_value that has not been removed: |
janezd
added some commits
Apr 5, 2019
janezd
force-pushed the
janezd:remove-base-value
branch
from
3109743
to
e388225
Apr 12, 2019
lanzagar
merged commit 2a5c848
into
biolab:master
Apr 12, 2019
5 checks passed
codecov/patch
98.23% of diff hit (target 95%)
Details
codecov/project
84.88% (+0.07%) compared to 80e4080
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
license/cla
Contributor License Agreement is signed.
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
janezd commentedApr 5, 2019
Issue
Closes #3690.
Description of changes
base_valuewas almost unused, and also not settable in the canvas, so we decided to remove it.Includes