Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upOWScatterplotGraph: Emit signals when resizing data points #3751
Conversation
janezd
requested a review
from
VesnaT
Apr 12, 2019
janezd
assigned
VesnaT
Apr 12, 2019
janezd
reviewed
Apr 12, 2019
| self.timer = QTimer(self.scatterplot_item, interval=50) | ||
| self.timer.timeout.connect(Timeout()) | ||
| self.timer.start() | ||
| else: | ||
| self.begin_resizing.emit() |
This comment has been minimized.
This comment has been minimized.
janezd
Apr 12, 2019
Author
Contributor
I know that this line repeats and could be before if, but I prefer having pairs begin-end.
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Apr 12, 2019
Codecov Report
@@ Coverage Diff @@
## master #3751 +/- ##
=========================================
+ Coverage 84.89% 84.9% +<.01%
=========================================
Files 374 374
Lines 68798 68815 +17
=========================================
+ Hits 58409 58426 +17
Misses 10389 10389 |
VesnaT
approved these changes
Apr 15, 2019
VesnaT
merged commit 9cf23e6
into
biolab:master
Apr 15, 2019
5 checks passed
codecov/patch
100% of diff hit (target 95%)
Details
codecov/project
84.9% (+<.01%) compared to f1b1616
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
license/cla
Contributor License Agreement is signed.
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
janezd commentedApr 12, 2019
Issue
In Network Explorer, I wanted to draw lines to the edge of the circles, not to the center. I tried to override
update_sizesto callself.update_edges()aftersuper().update_sizes()... but this didn't work becauseupdate_sizedoes not change sizes immediately but updates them from a separate thread.Furthermore, it would be nice if edges were animated together with circles.
Description of changes
I added signals that are emitted at the start and end of resize, and at each step.
Includes