Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] OWDistributions: add cumulative distribution #3766

Merged
merged 1 commit into from Apr 19, 2019

Conversation

Projects
None yet
2 participants
@rokgomiscek
Copy link
Contributor

commented Apr 19, 2019

Issue

Implements #1848.

Description of changes

Added check box to display cumulative ditribution.

Includes
  • Code changes
  • Tests
  • Documentation
@codecov

This comment has been minimized.

Copy link

commented Apr 19, 2019

Codecov Report

Merging #3766 into master will decrease coverage by <.01%.
The diff coverage is 54.54%.

@@            Coverage Diff            @@
##           master   #3766      +/-   ##
=========================================
- Coverage   84.91%   84.9%   -0.01%     
=========================================
  Files         374     374              
  Lines       68834   68845      +11     
=========================================
+ Hits        58447   58450       +3     
- Misses      10387   10395       +8
@janezd

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

Nice.

It is a bit weird that curves end at the maximal value, but on the other hand it gives additional information while improving ink/info ratio.

@janezd janezd merged commit de2e611 into biolab:master Apr 19, 2019

3 of 5 checks passed

codecov/patch 54.54% of diff hit (target 95%)
Details
codecov/project 84.9% (-0.01%) compared to f9ed02b
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@rokgomiscek rokgomiscek deleted the rokgomiscek:cumulativeDistribution branch Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.