Skip to content

/orange3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unite preprocessor handling in Learner-outputting widgets #898

Merged
merged 1 commit into from Dec 8, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@kernc @codecov-io @BlazZupan
@kernc
Copy link
Member

commented Dec 4, 2015

Apply user-provided preprocessors first, but always apply learner-dependent default ones afterwards so that algos just work™.

Requires default preprocessors to be idempotent, which SklLearner.preprocessors are.

@lanzagar, @VesnaT, @BlazZupan might want to review this?
@kernc
Unite preprocessor handling in Learner-outputting widgets 
Apply user-provided preprocessors first, but always apply learner-dependent
default ones afterwards so that algos just work™.

Requires default preprocessors to be idempotent, which `SklLearner.preprocessors`
are.
Loading status checks…
38446d3

@kernc kernc force-pushed the kernc:Preprocessors,unite! branch from 301176d to 38446d3 Dec 4, 2015

@codecov-io

This comment has been minimized.

Sign in to view
Copy link

commented Dec 4, 2015

Current coverage is 90.35%

Merging #898 into master will not affect coverage as of 6b4eca1

@@            master    #898   diff @@
======================================
  Files          143     143       
  Stmts        14651   14651       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit          13238   13238       
  Partial          0       0       
  Missed        1413    1413

Review entire Coverage Diff as of 6b4eca1

Powered by Codecov. Updated on successful CI builds.

BlazZupan added a commit that referenced this pull request Dec 8, 2015

@BlazZupan
Merge pull request #898 from kernc/Preprocessors,unite! 
Unite preprocessor handling in Learner-outputting widgets
Loading status checks…
f6979aa

@BlazZupan BlazZupan merged commit f6979aa into biolab:master Dec 8, 2015
2 checks passed

2 checks passed

codecov/project 90.35% remains the same compared to eb975cd
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.