Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprocess test data when evaluating learners #925

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@kernc
Copy link
Member

commented Dec 14, 2015

No description provided.

@kernc kernc force-pushed the kernc:preprocess-testing branch from 1c76423 to cfca7bf Dec 15, 2015

@codecov-io

This comment has been minimized.

Copy link

commented Dec 15, 2015

Current coverage is 90.39%

Merging #925 into master will increase coverage by +0.01% as of aeb90ed

@@            master    #925   diff @@
======================================
  Files          143     143       
  Stmts        14674   14684    +10
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit          13263   13274    +11
  Partial          0       0       
+ Missed        1411    1410     -1

Review entire Coverage Diff as of aeb90ed

Powered by Codecov. Updated on successful CI builds.

@lanzagar

This comment has been minimized.

Copy link
Contributor

commented Dec 15, 2015

This uses preprocessors on test data and applies them on training data.
Learners should not get information from the test data before fitting the model as it can lead to (misleadingly) higher evaluation scores.

@kernc

This comment has been minimized.

Copy link
Member Author

commented Dec 15, 2015

Closed in favor of #598.

@kernc kernc closed this Dec 15, 2015

@kernc kernc deleted the kernc:preprocess-testing branch Jan 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.