Skip to content

/orange3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OWSaveClassifier: append .pickle extension if not already provided #957

Merged
merged 1 commit into from Jan 8, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@kernc @codecov-io @janezd
@kernc
@kernc

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Dec 28, 2015

An interesting, ambiguity-preventing alternative would be to introduce a new extension for pickled classifiers, e.g. .pkcls. Done.
@codecov-io

This comment has been minimized.

Sign in to view
Copy link

commented Dec 28, 2015

Current coverage is 90.41%

Merging #957 into master will not affect coverage as of 9ae1820

@@            master    #957   diff @@
======================================
  Files          143     143       
  Stmts        14688   14688       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit          13280   13280       
  Partial          0       0       
  Missed        1408    1408

Review entire Coverage Diff as of 9ae1820

Powered by Codecov. Updated on successful CI builds.

@kernc kernc force-pushed the kernc:fix-saveclassifier branch from 453b804 to e2a2bdc Dec 28, 2015

Orange/widgets/classify/owsaveclassifier.py Outdated
@@ -22,7 +22,9 @@ class OWSaveClassifier(widget.OWWidget):
#: A list of recent filenames.
history = Setting([])

FILTER = "Pickle files (*.pickle *.pck)\nAll files (*.*)"

SUPPORTED_EXTENSIONS = ('.pkcls', '.pickle', '.pkl')

This comment has been minimized.

Sign in to view
Copy link
@janezd

janezd Dec 28, 2015

Contributor

We're beginning to have too many extensions. Can we decide for just one? I like pkcls. Same for data, where we would use pkdata.

This comment has been minimized.

Sign in to view
Copy link
@kernc

kernc Dec 28, 2015

Author Member

There's a thing called backward compatibility. But there's All Files option, so .pkcls it is ...

@kernc kernc force-pushed the kernc:fix-saveclassifier branch 3 times, most recently from 2c4f337 to 8b6ad0c Dec 28, 2015

@kernc kernc force-pushed the kernc:fix-saveclassifier branch from 8b6ad0c to 31a0da9 Dec 29, 2015

janezd added a commit that referenced this pull request Jan 8, 2016

@janezd
Merge pull request #957 from kernc/fix-saveclassifier 
OWSaveClassifier: append .pickle extension if not already provided
Loading status checks…
4b10dff

@janezd janezd merged commit 4b10dff into biolab:master Jan 8, 2016
2 checks passed

2 checks passed

codecov/project 90.41% remains the same compared to bd8d551
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kernc kernc deleted the kernc:fix-saveclassifier branch Jan 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.