Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📎 Pin bench libs #3196

Open
Sec-ant opened this issue Jun 13, 2024 · 0 comments
Open

📎 Pin bench libs #3196

Sec-ant opened this issue Jun 13, 2024 · 0 comments
Labels
A-Tooling Area: internal tools good first issue Good for newcomers S-Enhancement Status: Improve an existing feature

Comments

@Sec-ant
Copy link
Member

Sec-ant commented Jun 13, 2024

Description

Many of the libraries we use for benchmarking are not pinned to a specific version but rather a branch that are actively updated, and we also don't compare their content hash to decide whether to update them if we already have their local copies in the target path.

We should pin those libs to specific commit hashes or concrete version numbers, and I think we should also use CDNs like jsDelivr to replace those raw.githubusercontent.com links for the benefit of the speed and accessibility across the world (yes, in some places the GitHub urls are blocked :( )

The links that need to be updated and pinned are in https://github.com/biomejs/biome/tree/main/xtask/bench/benches

We can use this page to convert a raw.githubusercontent.com url into a https://cdn.jsdelivr.net/gh/ url. We can also check this page to understand the different forms of the url.

Additionally, we should use the pattern [name].[content-hash].[extension] to save and validate lib files. The code is in https://github.com/biomejs/biome/blob/main/xtask/bench/src/test_case.rs

@Sec-ant Sec-ant added good first issue Good for newcomers A-Tooling Area: internal tools S-Enhancement Status: Improve an existing feature labels Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Tooling Area: internal tools good first issue Good for newcomers S-Enhancement Status: Improve an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant