Skip to content

Conversation

@oki07
Copy link
Contributor

@oki07 oki07 commented May 23, 2024

Summary

close #2807
Implement declaration-block-no-shorthand-property-overrides

Test Plan

added tests and snapshots

@github-actions github-actions bot added A-Project Area: project L-CSS Language: CSS A-Diagnostic Area: diagnostocis labels May 23, 2024
@oki07 oki07 force-pushed the feat/no-shorthand-property-overrides branch from 4fac6ab to 8df660d Compare May 29, 2024 12:32
@codspeed-hq
Copy link

codspeed-hq bot commented May 29, 2024

CodSpeed Performance Report

Merging #2958 will degrade performances by 16.26%

Comparing neokidev:feat/no-shorthand-property-overrides (9b8bbd7) with main (bf5b4dd)

Summary

❌ 5 (👁 5) regressions
✅ 87 untouched benchmarks

Benchmarks breakdown

Benchmark main neokidev:feat/no-shorthand-property-overrides Change
👁 css_analyzer[bootstrap.css] 206.3 ms 221 ms -6.63%
👁 css_analyzer[bulma.css] 77.3 ms 87.9 ms -12.03%
👁 css_analyzer[foundation.css] 45.5 ms 54.3 ms -16.26%
👁 css_analyzer[pure.css] 5.3 ms 6.2 ms -14.66%
👁 css_analyzer[tachyons.css] 33.9 ms 40 ms -15.31%

@oki07 oki07 force-pushed the feat/no-shorthand-property-overrides branch from 9010ac4 to 41eacf2 Compare June 1, 2024 05:56
@oki07 oki07 marked this pull request as ready for review June 1, 2024 06:37
@oki07 oki07 requested a review from ematipico June 1, 2024 10:27
@oki07 oki07 force-pushed the feat/no-shorthand-property-overrides branch from fe06e4c to f1e27dd Compare June 5, 2024 11:50
@oki07 oki07 requested a review from togami2864 June 5, 2024 15:55
@oki07 oki07 changed the title feat(biome_css_analyze): noShorthandPropertyOverrides feat(biome_css_analyzer): noShorthandPropertyOverrides Jun 10, 2024
@ematipico
Copy link
Member

I believe we can accept the regressions for now

@ematipico ematipico merged commit 746db0a into biomejs:main Jun 10, 2024
@ematipico
Copy link
Member

@neokidev can you send a PR to update the changelog?

@oki07
Copy link
Contributor Author

oki07 commented Jun 10, 2024

@neokidev can you send a PR to update the changelog?

@ematipico I created the PR(#3163).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Diagnostic Area: diagnostocis A-Project Area: project L-CSS Language: CSS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

📎 Implement declaration-block-no-shorthand-property-overrides

3 participants