Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a .travis.yml file. #3

Merged
merged 4 commits into from Oct 4, 2017
Merged

Added a .travis.yml file. #3

merged 4 commits into from Oct 4, 2017

Conversation

@StuntsPT
Copy link
Member

@StuntsPT StuntsPT commented Jun 3, 2017

As per the title. Fixes #2

@StuntsPT StuntsPT self-assigned this Jun 3, 2017
@StuntsPT StuntsPT requested a review from bmpvieira Jun 3, 2017
@bmpvieira bmpvieira added this to In Progress in Bionode Project Board Jun 13, 2017
@bmpvieira
Copy link
Member

@bmpvieira bmpvieira commented Aug 23, 2017

No tests for Travis to run. You could add dependency-check && standard to the package.json

@bmpvieira bmpvieira moved this from In Progress to Backlog in Bionode Project Board Aug 23, 2017
@StuntsPT
Copy link
Member Author

@StuntsPT StuntsPT commented Aug 25, 2017

So I have added the tests, and solved most of the issues that were revealed.
However, I fear that by removing the offending lines some code will break, eg.
lib/constants.js:6:7: 'BASE_URL' is assigned a value but never used.
BASE_URL is never used in constants.js, but is used in retrieve.js like so: const { BASE_URL } = require('./constants.js')

@bmpvieira bmpvieira moved this from Backlog to In Progress in Bionode Project Board Aug 29, 2017
@bmpvieira bmpvieira moved this from In Progress to Backlog in Bionode Project Board Aug 29, 2017
@bmpvieira bmpvieira requested review from thejmazz and removed request for bmpvieira Oct 4, 2017
@thejmazz thejmazz merged commit e8bc8ab into master Oct 4, 2017
1 of 3 checks passed
@thejmazz thejmazz deleted the travis_yml branch Oct 4, 2017
@bmpvieira bmpvieira moved this from Backlog to Done in Bionode Project Board Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants