Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardization #3

Merged
merged 7 commits into from Aug 28, 2017
Merged

Standardization #3

merged 7 commits into from Aug 28, 2017

Conversation

@StuntsPT
Copy link
Member

@StuntsPT StuntsPT commented Jun 2, 2017

Standardized README.md, improved "Standard JS" conformance, bumped package versions and added new unit tests.

@StuntsPT StuntsPT self-assigned this Jun 2, 2017
@StuntsPT StuntsPT requested a review from bmpvieira Jun 2, 2017
@bmpvieira bmpvieira added this to In Progress in Bionode Project Board Jun 2, 2017
Copy link
Member

@bmpvieira bmpvieira left a comment

One small change.

@@ -7,7 +7,7 @@
"test": "test"
},
"scripts": {
"test": "./node_modules/mocha/bin/mocha"
"test": "./node_modules/mocha/bin/mocha && standard && dependency-check ."

This comment has been minimized.

@bmpvieira

bmpvieira Aug 23, 2017
Member

standard && dependency-check . && mocha to be like in other modules

@StuntsPT
Copy link
Member Author

@StuntsPT StuntsPT commented Aug 25, 2017

Testing line was standardized as per your request!

@bmpvieira bmpvieira merged commit 3fb4486 into master Aug 28, 2017
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No new vulnerabilities
Details
@bmpvieira bmpvieira deleted the standardization branch Aug 28, 2017
@bmpvieira bmpvieira moved this from In Progress to Done in Bionode Project Board Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants