Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
User-friendly errors #12
Simply will throw error in case an object from NCBI has undefined properties that are required by bionode. The message will mention this could be an NCBI problem, and show the URL of the request.
Test data was out of date and making travis CI fail for the current blonde-ncbi. I updated test/data.json to have current ncbi data and make tests pass. Some fetched with script here + manual changes such as replacing 'content' with '_'.
@bmpvieira Do you want me to add do a test for the error handling? The error occurs when transform gets an empty object. I guess the testing could be done by mocking the ncbi url using nock or something, and send back an empty/invalid object, to trigger the error.