New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests (#18) and mocking NCBI API #21
Merged
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7d89298
Fix style according to StandardJS
bmpvieira 3b43c58
Update tests data
bmpvieira 2ad5ae3
Add tape-nock module to tests
bmpvieira 57df401
Add fixtures (with git-lfs) for mocking NCBI API and fix #18
bmpvieira d76760f
Update Node version on Travis and reduce verbosity
bmpvieira ec1d116
Add git-lfs to Travis
bmpvieira a6a15ad
Update dependencies and make new nugget quiet
bmpvieira 3d3ac5a
Fix confusing var declaration in cli.js
bmpvieira File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
test/fixtures/Download[[:space:]]list[[:space:]]for[[:space:]]assembly_.json filter=lfs diff=lfs merge=lfs -text | ||
test/fixtures/Download[[:space:]]list[[:space:]]for[[:space:]]sra_.json filter=lfs diff=lfs merge=lfs -text | ||
test/fixtures/Download[[:space:]]unless[[:space:]]file[[:space:]]exists_.json filter=lfs diff=lfs merge=lfs -text | ||
test/fixtures/Download_.json filter=lfs diff=lfs merge=lfs -text | ||
test/fixtures/Fetch_.json filter=lfs diff=lfs merge=lfs -text | ||
test/fixtures/Link[[:space:]]bioproject[[:space:]]to[[:space:]]assembly_.json filter=lfs diff=lfs merge=lfs -text | ||
test/fixtures/Link[[:space:]]sra[[:space:]]to[[:space:]]bioproject_.json filter=lfs diff=lfs merge=lfs -text | ||
test/fixtures/Search[[:space:]]assembly_.json filter=lfs diff=lfs merge=lfs -text | ||
test/fixtures/Search[[:space:]]sra[[:space:]]with[[:space:]]limit[[:space:]]to[[:space:]]one_.json filter=lfs diff=lfs merge=lfs -text | ||
test/fixtures/Search[[:space:]]sra_.json filter=lfs diff=lfs merge=lfs -text | ||
503988/GCF_000315625.1_Guith1_genomic.fna.gz filter=lfs diff=lfs merge=lfs -text |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,3 +2,5 @@ node_modules | |
.DS_Store | ||
coverage | ||
tmp | ||
503988 | ||
test/fixtures |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git LFS file not shown
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,14 @@ | ||
// Anonymous usage metrics for debug and funding, if user agrees | ||
const Insight = require('insight'); | ||
const pkg = require('../package.json'); | ||
const Insight = require('insight') | ||
const pkg = require('../package.json') | ||
|
||
const insight = new Insight({ | ||
// Google Analytics tracking code | ||
trackingCode: 'UA-54802258-3', | ||
pkg | ||
}); | ||
}) | ||
if (insight.optOut === undefined) { | ||
insight.askPermission("Bionode is open and free. Can we anonymously report usage statistics for improvement and funding purposes?"); | ||
insight.askPermission('Bionode is open and free. Can we anonymously report usage statistics for improvement and funding purposes?') | ||
} | ||
|
||
module.exports = insight | ||
module.exports = insight |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These variables aren't declared if command !== 'link'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are declared because JavaScript doesn't have block scope, only function scope, so they get hoisted. However, this might be confusing so I'll fix it. Thanks for noticing it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍