This repository was archived by the owner on May 18, 2026. It is now read-only.
Repository navigation
Prevent progress bar from starting if file already exists - #30
Merged
Merged
Conversation
bmpvieira
self-requested a review
April 17, 2017 09:33
tiagofilipe12
force-pushed
the
progress-bar
branch
2 times, most recently
from
April 19, 2017 18:24
3cfa511 to
3cd411b
Compare
tiagofilipe12
force-pushed
the
progress-bar
branch
from
April 20, 2017 14:16
3cd411b to
0ed9dd4
Compare
bmpvieira
approved these changes
Apr 20, 2017
bmpvieira
left a comment
bmpvieira
left a comment
Member
There was a problem hiding this comment.
Looks good thanks! Long term, we might want to change how we deal with errors and info. #29 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change only affects --pretty option, and prevents progress bar from starting when file already exists, which rendered an odd 0% progress when output already exists in file system. Makes more sense if we raise an error message and do not start progress bar at all.