Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent progress bar from starting if file already exists #30

Merged
merged 1 commit into from Apr 20, 2017

Conversation

@tiagofilipe12
Copy link
Member

@tiagofilipe12 tiagofilipe12 commented Apr 16, 2017

This change only affects --pretty option, and prevents progress bar from starting when file already exists, which rendered an odd 0% progress when output already exists in file system. Makes more sense if we raise an error message and do not start progress bar at all.

@tiagofilipe12 tiagofilipe12 added the ux label Apr 16, 2017
@bmpvieira bmpvieira added this to In Progress in Bionode Project Board Apr 17, 2017
@bmpvieira bmpvieira self-requested a review Apr 17, 2017
@tiagofilipe12 tiagofilipe12 force-pushed the progress-bar branch 2 times, most recently from 3cfa511 to 3cd411b Apr 19, 2017
@tiagofilipe12 tiagofilipe12 force-pushed the progress-bar branch from 3cd411b to 0ed9dd4 Apr 20, 2017
Copy link
Member

@bmpvieira bmpvieira left a comment

Looks good thanks! Long term, we might want to change how we deal with errors and info. #29 (comment)

@tiagofilipe12 tiagofilipe12 merged commit 53ac37e into master Apr 20, 2017
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 81.05%
Details
@bmpvieira bmpvieira moved this from In Progress to Done in Bionode Project Board Apr 20, 2017
bmpvieira added a commit that referenced this pull request Apr 22, 2017
Switch from minimist to yargs for CLI parsing
Add list of possible databases with yargs
Indent JSON output when --pretty
Allow piping JSON, even for fetch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants