Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from dld to nugget, upgrade some dependencies #5

Merged
merged 1 commit into from Oct 22, 2014

Conversation

@maxogden
Copy link
Contributor

@maxogden maxogden commented Oct 21, 2014

I only realized after I implemented this that I think you already handled the case where bionode-ncbi would skip downloading if the file already exists locally, but I finished this PR nonetheless since nugget handles that automatically and at least this removes more code than it adds :)

@maxogden

This comment has been minimized.

Copy link
Contributor Author

@maxogden maxogden commented on test/bionode-ncbi.js in 2b07987 Oct 21, 2014

i was debugging something and ended up rewriting this test stream using through2. I later found out it wasnt strictly necessary but I decided to keep it in because it's better to use streams2 | streams2 rather than bind .on('data' listeners

@maxogden

This comment has been minimized.

Copy link
Contributor Author

@maxogden maxogden commented on lib/bionode-ncbi.js in 2b07987 Oct 21, 2014

recently .destroy got added to through2 (i updated to a more recent version in this PR too)

@coveralls
Copy link

@coveralls coveralls commented Oct 21, 2014

Coverage Status

Changes Unknown when pulling 2b07987 on maxogden:nugget into * on bionode:master*.

bmpvieira added a commit that referenced this pull request Oct 22, 2014
switch from dld to nugget, upgrade some dependencies
@bmpvieira bmpvieira merged commit 1f0b53a into bionode:master Oct 22, 2014
1 check passed
1 check passed
@bmpvieira
continuous-integration/travis-ci The Travis CI build passed
Details
@bmpvieira
Copy link
Member

@bmpvieira bmpvieira commented Oct 22, 2014

Awesome PR, thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants