New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardization #6

Merged
merged 7 commits into from Aug 28, 2017

Conversation

2 participants
@StuntsPT
Member

StuntsPT commented Jun 2, 2017

Added CONTRIBUTING.md, standardized README.md, improved "Standard JS" conformance, bumped package versions, removed spammy notifications and removed unimplemented tests. Fixes #5 .

@StuntsPT StuntsPT self-assigned this Jun 2, 2017

@StuntsPT StuntsPT requested a review from bmpvieira Jun 2, 2017

@bmpvieira bmpvieira added this to In Progress in Bionode Project Board Jun 3, 2017

@bmpvieira

Just need to keep mocha in tests

@@ -40,7 +42,7 @@
},
"scripts": {
"preinstall": "sam/build.sh",
"test": "mocha --reporter spec",
"test": "standard && dependency-check .",

This comment has been minimized.

@bmpvieira

bmpvieira Aug 23, 2017

Member

Please keep mocha here after the other tests.

@StuntsPT

This comment has been minimized.

Member

StuntsPT commented Aug 25, 2017

Added the mocha tests back. However, a new error shows up complaining there are no tests to perform...

@bmpvieira

This comment has been minimized.

Member

bmpvieira commented Aug 28, 2017

Sorry, I didn't see that tests were still missing. I'll merge your changes anyway and someone can add tests later.

@bmpvieira bmpvieira merged commit d5a3aa6 into master Aug 28, 2017

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
security/snyk No new vulnerabilities
Details

@bmpvieira bmpvieira deleted the standardization branch Aug 28, 2017

@bmpvieira bmpvieira moved this from In Progress to Done in Bionode Project Board Aug 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment