New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the CheckType function #1

Merged
merged 3 commits into from Nov 9, 2014

Conversation

3 participants
@IsmailM
Member

IsmailM commented Sep 22, 2014

Let me know what you think...

Here is a comparison between the original and the updated version... http://jsbin.com/fofadedopodu/1/edit?js,output

Note: Since ACGT are both bases and amino acid, it is sometime impossible to work out which type the sequence is... So this script checks if the sequence is DNA (or RNA) before, checking if it could be a protein (since for it to be a DNA or RNA sequence, there must be a higher percentage of ACGT). You can see an example of this problem in the above link...

BTW. I'm not too sure about line 10 on the test unit - is the undefined supposed to be in the apostrophes?

Also I haven't checked if the unit tests work...

@coveralls

This comment has been minimized.

coveralls commented Nov 7, 2014

Coverage Status

Changes Unknown when pulling 1a5a317 on IsmailM:master into * on bionode:master*.

bmpvieira added a commit that referenced this pull request Nov 9, 2014

Merge pull request #1 from IsmailM/master
Updating the CheckType function

@bmpvieira bmpvieira merged commit 8d56f37 into bionode:master Nov 9, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

bmpvieira added a commit that referenced this pull request Apr 20, 2015

Merge pull request #1 from IsmailM/master
Updating the CheckType function

@bmpvieira bmpvieira self-requested a review Apr 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment