Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting fix and https fix for sra toolkit download #5

Merged
merged 2 commits into from Apr 6, 2017

Conversation

2 participants
@amanjeev
Copy link
Contributor

amanjeev commented Feb 5, 2017

Hi @bmpvieira ! I made some minor changes to the repo. It fails to be installed because the url for SRA toolkit download was http. so I updates the Makefile.

I also formatted the code a bit.

@bmpvieira

This comment has been minimized.

Copy link
Member

bmpvieira commented Feb 28, 2017

Hey @amanjeev ! Thanks for the PR!! Would you just mind to follow the standardjs.com style?

Cheers,
Bruno

@amanjeev

This comment has been minimized.

Copy link
Contributor Author

amanjeev commented Feb 28, 2017

@bmpvieira bmpvieira added this to In Progress in Bionode Project Board Mar 29, 2017

@bmpvieira bmpvieira added the bug label Mar 29, 2017

amanjeev added a commit to amanjeev/bionode-sra that referenced this pull request Apr 6, 2017

@amanjeev

This comment has been minimized.

Copy link
Contributor Author

amanjeev commented Apr 6, 2017

Sorry it took longer than usual for merely formatting the code. Should be good now. I just used standard --fix.

@bmpvieira

This comment has been minimized.

Copy link
Member

bmpvieira commented Apr 6, 2017

No problem @amanjeev! One last thing, could you undo the changes to the comments? Those comments are formatted that way and used to generate the documentation with npm run build-docs. Thank you!

@amanjeev amanjeev force-pushed the amanjeev:fix-latest-node branch from 4404e9e to 3591cff Apr 6, 2017

@amanjeev

This comment has been minimized.

Copy link
Contributor Author

amanjeev commented Apr 6, 2017

Sorry about this fiasco! I've reset the entire branch and just made the relevant changes. Now only two commits, what it should have been in the beginning anyway. :)

@bmpvieira bmpvieira self-requested a review Apr 6, 2017

@bmpvieira

This comment has been minimized.

Copy link
Member

bmpvieira commented Apr 6, 2017

ahah don't worry, next time will be better! :)

@bmpvieira
Copy link
Member

bmpvieira left a comment

Looks good! Thank you for spending your time on this. :)

@bmpvieira bmpvieira merged commit 1bfd997 into bionode:master Apr 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bmpvieira bmpvieira moved this from In Progress to Done in Bionode Project Board Apr 6, 2017

@amanjeev

This comment has been minimized.

Copy link
Contributor Author

amanjeev commented Apr 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.