Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency removal (fs) #4

Merged
merged 1 commit into from Apr 4, 2017
Merged

Dependency removal (fs) #4

merged 1 commit into from Apr 4, 2017

Conversation

@amblina
Copy link
Contributor

@amblina amblina commented Oct 30, 2016

Heya, just a quickie-PR. This package is a spam/placeholder package in npm which doesn't serve any purpose other than being an extra dependency. The fs module is built-in so there is no need to explicitly add it to the dependency list. There's more info on this here: https://www.npmjs.com/package/fs and here: http://status.npmjs.org/incidents/dw8cr1lwxkcr. 馃槂

@amblina amblina changed the title Dependency removal Dependency removal (fs) Oct 30, 2016
@shyamrallapalli shyamrallapalli merged commit bd8e575 into bionode:master Apr 4, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bmpvieira bmpvieira requested a review from shyamrallapalli Apr 6, 2017
@amblina amblina deleted the amblina:patch-1 branch Apr 6, 2017
@bmpvieira bmpvieira added the bug label Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants