Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardization #6

Merged
merged 9 commits into from Aug 28, 2017
Merged

Standardization #6

merged 9 commits into from Aug 28, 2017

Conversation

StuntsPT
Copy link
Member

@StuntsPT StuntsPT commented Jun 2, 2017

Documentation standardizations, better "Standard JS" conformance, bumped package versions and implemented "Standard JS" tests.

@bmpvieira bmpvieira added this to In Progress in Bionode Project Board Jun 2, 2017
Copy link
Member

@bmpvieira bmpvieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs two small changes.

lib/index.js Outdated


if (line.indexOf('#') === 0) {
// ##fileformat=VCFv4.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fix the indentation of the comments here and below?

package.json Outdated
@@ -22,16 +22,18 @@
],
"main": "lib/index.js",
"scripts": {
"test": "mocha"
"test": "standard && dependency-check ."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should keep the mocha testing here, like standard && dependency-check . && mocha

@StuntsPT
Copy link
Member Author

These two commits should handle your concerns. Unless I got the indentation wrong...

@bmpvieira bmpvieira merged commit 30c536b into master Aug 28, 2017
@bmpvieira bmpvieira deleted the standardization branch August 28, 2017 15:43
@bmpvieira bmpvieira moved this from In Progress to Done in Bionode Project Board Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants