New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardization #6

Merged
merged 9 commits into from Aug 28, 2017

Conversation

2 participants
@StuntsPT
Member

StuntsPT commented Jun 2, 2017

Documentation standardizations, better "Standard JS" conformance, bumped package versions and implemented "Standard JS" tests.

@StuntsPT StuntsPT requested a review from bmpvieira Jun 2, 2017

@StuntsPT StuntsPT self-assigned this Jun 2, 2017

@bmpvieira bmpvieira added this to In Progress in Bionode Project Board Jun 2, 2017

@bmpvieira

Looks good, just needs two small changes.

if (line.indexOf('#') === 0) {
// ##fileformat=VCFv4.1

This comment has been minimized.

@bmpvieira

bmpvieira Aug 23, 2017

Member

Can you please fix the indentation of the comments here and below?

@@ -22,16 +22,18 @@
],
"main": "lib/index.js",
"scripts": {
"test": "mocha"
"test": "standard && dependency-check ."

This comment has been minimized.

@bmpvieira

bmpvieira Aug 23, 2017

Member

You should keep the mocha testing here, like standard && dependency-check . && mocha

@StuntsPT

This comment has been minimized.

Member

StuntsPT commented Aug 25, 2017

These two commits should handle your concerns. Unless I got the indentation wrong...

@bmpvieira bmpvieira merged commit 30c536b into master Aug 28, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No new vulnerabilities
Details

@bmpvieira bmpvieira deleted the standardization branch Aug 28, 2017

@bmpvieira bmpvieira moved this from In Progress to Done in Bionode Project Board Aug 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment