Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upSanitization and tidy up of Dockerfile #4
Conversation
tiagofilipe12
self-requested a review
Aug 10, 2017
tiagofilipe12
assigned
ODiogoSilva
Aug 10, 2017
tiagofilipe12
added
the
enhancement
label
Aug 10, 2017
tiagofilipe12
approved these changes
Aug 10, 2017
|
This is a nice cleanup on the dockerfile. Thank you! |
tiagofilipe12
merged commit c2548ff
into
bionode:master
Aug 10, 2017
bmpvieira
added this to Done
in Bionode Project Board
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ODiogoSilva commentedAug 10, 2017
Made some changes so that the Dockerfile better adheres the dockerfile best practices (https://docs.docker.com/engine/userguide/eng-image/dockerfile_best-practices/).
The setup of third party applications (bowtie2, bwa, etc) is no longer performed directly on /bin. Instead, temporary packages and compilations are done in /tmp/, the relevant binaries are moved to /usr/bin/ and all else is removed at the end.
Also changed final working directory to be under /home instead of /bin.