Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitization and tidy up of Dockerfile #4

Merged
merged 1 commit into from Aug 10, 2017

Conversation

2 participants
@ODiogoSilva
Copy link
Contributor

ODiogoSilva commented Aug 10, 2017

Made some changes so that the Dockerfile better adheres the dockerfile best practices (https://docs.docker.com/engine/userguide/eng-image/dockerfile_best-practices/).

The setup of third party applications (bowtie2, bwa, etc) is no longer performed directly on /bin. Instead, temporary packages and compilations are done in /tmp/, the relevant binaries are moved to /usr/bin/ and all else is removed at the end.

Also changed final working directory to be under /home instead of /bin.

@tiagofilipe12
Copy link
Member

tiagofilipe12 left a comment

This is a nice cleanup on the dockerfile. Thank you! 👍

@tiagofilipe12 tiagofilipe12 merged commit c2548ff into bionode:master Aug 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.