New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if file is empty #51

Closed
tiagofilipe12 opened this Issue Jun 1, 2017 · 3 comments

Comments

3 participants
@tiagofilipe12
Member

tiagofilipe12 commented Jun 1, 2017

While running a task watermill should check if file is empty before executing it. One simple way to do so would be to check if file size is 0.

@tiagofilipe12 tiagofilipe12 added the bug label Jun 1, 2017

@bmpvieira bmpvieira added this to Backlog in Bionode Project Board Jun 1, 2017

@bmpvieira bmpvieira added the mozsprint label Jun 2, 2017

@thejmazz

This comment has been minimized.

Member

thejmazz commented Jun 2, 2017

There is code for this but it was toggled off near the end of my GSOC.

This is part of "validators", which can be ran before a task, after a task, and later we should add the ability for users to pass per filetype validators per task, stream validators (i.e. check if each object has required keys), etc

@thejmazz

This comment has been minimized.

Member

thejmazz commented Jun 2, 2017

We should close this issue once that validation is re-enabled and we have tests for this

@tiagofilipe12

This comment has been minimized.

Member

tiagofilipe12 commented Jul 20, 2017

Since I couldn't replicate this I will close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment