Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize traverse for resolving functions #8

Closed
thejmazz opened this issue Jul 4, 2016 · 0 comments
Closed

Generalize traverse for resolving functions #8

thejmazz opened this issue Jul 4, 2016 · 0 comments
Assignees
Labels
Milestone

Comments

@thejmazz
Copy link
Member

@thejmazz thejmazz commented Jul 4, 2016

Code is duplicated a few times, had a function before but it was not flexible enough

Need to be careful about infinite recursion, if default in the switch calls itself repeatedly

https://github.com/bionode/bionode-waterwheel/blob/3dcaca6b7af2f73ab1abe8e1abb92ed02f745f8c/lib/Task.js#L51-L79

https://github.com/bionode/bionode-waterwheel/blob/3dcaca6b7af2f73ab1abe8e1abb92ed02f745f8c/lib/Task.js#L82-L110

https://github.com/bionode/bionode-waterwheel/blob/3dcaca6b7af2f73ab1abe8e1abb92ed02f745f8c/lib/Task.js#L179-L204

@thejmazz thejmazz added this to the v0.2 milestone Jul 4, 2016
thejmazz added a commit that referenced this issue Jul 4, 2016
thejmazz added a commit that referenced this issue Jul 4, 2016
@thejmazz thejmazz closed this Jul 5, 2016
thejmazz added a commit that referenced this issue Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants