Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upGeneralize traverse for resolving functions #8
Comments
thejmazz
added this to the v0.2 milestone
Jul 4, 2016
added a commit
that referenced
this issue
Jul 4, 2016
added a commit
that referenced
this issue
Jul 4, 2016
thejmazz
closed this
Jul 5, 2016
added a commit
that referenced
this issue
Jul 5, 2016
bmpvieira
added this to Done
in Bionode Project Board
Mar 29, 2017
bmpvieira
added
the
enhancement
label
Mar 29, 2017
bmpvieira
assigned
thejmazz
Apr 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
thejmazz commentedJul 4, 2016
Code is duplicated a few times, had a function before but it was not flexible enough
Need to be careful about infinite recursion, if
defaultin the switch calls itself repeatedlyhttps://github.com/bionode/bionode-waterwheel/blob/3dcaca6b7af2f73ab1abe8e1abb92ed02f745f8c/lib/Task.js#L51-L79
https://github.com/bionode/bionode-waterwheel/blob/3dcaca6b7af2f73ab1abe8e1abb92ed02f745f8c/lib/Task.js#L82-L110
https://github.com/bionode/bionode-waterwheel/blob/3dcaca6b7af2f73ab1abe8e1abb92ed02f745f8c/lib/Task.js#L179-L204