Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct path to home folder #48

Merged
merged 1 commit into from May 17, 2017
Merged

correct path to home folder #48

merged 1 commit into from May 17, 2017

Conversation

tiagofilipe12
Copy link
Member

This corrects the path of the "require" to the bionode-watermill home folder.

@codecov-io
Copy link

codecov-io commented May 17, 2017

Codecov Report

Merging #48 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   80.64%   80.64%           
=======================================
  Files          36       36           
  Lines         806      806           
  Branches       99       99           
=======================================
  Hits          650      650           
  Misses        156      156

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9600dbd...cc8b3bc. Read the comment docs.

Copy link
Member

@thejmazz thejmazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe eventually we can use some variable or something for this path among different example files. they essentially need to require what is defined by main in package.json to simulate an npm install

@thejmazz thejmazz merged commit b19a8d3 into master May 17, 2017
@thejmazz thejmazz deleted the path_fix branch May 17, 2017 19:05
@bmpvieira bmpvieira added the bug label May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants