Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docker related links and added link to tutorial in README #56

Merged
merged 6 commits into from Jun 22, 2017

Conversation

@tiagofilipe12
Copy link
Member

@tiagofilipe12 tiagofilipe12 commented Jun 13, 2017

Performed the updates described in the title.

@codecov-io
Copy link

@codecov-io codecov-io commented Jun 13, 2017

Codecov Report

Merging #56 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   80.64%   80.64%           
=======================================
  Files          36       36           
  Lines         806      806           
  Branches       99       99           
=======================================
  Hits          650      650           
  Misses        156      156

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9bdd40...b9cfce8. Read the comment docs.

Loading

@tiagofilipe12
Copy link
Member Author

@tiagofilipe12 tiagofilipe12 commented Jun 14, 2017

Added tutorial and blog entry about work-flow managers to main README.md. You can now check it and see if everything is ok and if so merge it. However, note that issue 49 should also address the creation of tasks with js functions and streams.

Loading

@tiagofilipe12
Copy link
Member Author

@tiagofilipe12 tiagofilipe12 commented Jun 20, 2017

Added a way to create a manifest file that allow to make a correspondence between folders created within data and the task names.

Loading

// First handles the possibility of input, output and params being an
// object rather than a string (e.g. when multiple params are passed to
// the task).
let string_output = JSON.stringify(originalTask.output)
Copy link
Member

@thejmazz thejmazz Jun 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use camelCase

Loading

let string_params = JSON.stringify(originalTask.params)
// Then creates the string to be written to the log file
let manifest_log =
`{ folder_name: "${originalTask.dir}",
Copy link
Member

@thejmazz thejmazz Jun 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should just be an object that you stringify

Loading

output: ${string_output},
params: ${string_params} }\n`
// Writes to the file
fs.appendFile('summary_log.txt', manifest_log, function (err) {
Copy link
Member

@thejmazz thejmazz Jun 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe logfile should be ndjson (one json object per line)

Loading

@tiagofilipe12
Copy link
Member Author

@tiagofilipe12 tiagofilipe12 commented Jun 20, 2017

I have separated the tutorial updates from the summary log file commits, in order to simplify the revision. So, if you feel this is ok, please feel free to merge.

Loading

@thejmazz thejmazz merged commit 7fba1c8 into bionode:master Jun 22, 2017
4 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants