Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary file #57

wants to merge 10 commits into from


Copy link

This is an initial PR for developing the manifest file.

Copy link

codecov-io commented Jun 22, 2017

Codecov Report

Merging #57 into master will increase coverage by 0.46%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #57      +/-   ##
+ Coverage   80.64%   81.1%   +0.46%     
  Files          36      36              
  Lines         806     831      +25     
  Branches       99     104       +5     
+ Hits          650     674      +24     
- Misses        156     157       +1
Impacted Files Coverage Δ
lib/sagas/lifecycle.js 89.34% <85.71%> (-0.23%) ⬇️
lib/orchestrators/join.js 96.77% <0%> (+1.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fba1c8...57ee8b8. Read the comment docs.

Copy link

I'll try to take a look at this soon but I have a midterm on Tuesday.

Copy link
Member Author

If we do #60 we can ignore this PR.

Copy link
Member Author

Ignore this PR, it will get deprecated with #62 .

@tiagofilipe12 tiagofilipe12 moved this from In Progress to Done in Bionode Project Board Jul 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Successfully merging this pull request may close these issues.

None yet

3 participants