New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented redux-logger given an environmental variable #61

Merged
merged 1 commit into from Jul 7, 2017

Conversation

3 participants
@tiagofilipe12
Member

tiagofilipe12 commented Jul 6, 2017

In this PR implemented a check for an environmental variable that changes the middlewares within lib/watermill.js. If REDUX_LOGGER=1 in environment the pipeline will execute redux-logger.
Also redux-logger package was updated in this PR.

@tiagofilipe12 tiagofilipe12 self-assigned this Jul 6, 2017

@tiagofilipe12 tiagofilipe12 requested a review from thejmazz Jul 6, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Jul 6, 2017

Codecov Report

Merging #61 into master will increase coverage by 0.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   80.64%   80.66%   +0.01%     
==========================================
  Files          36       36              
  Lines         806      812       +6     
  Branches       99      100       +1     
==========================================
+ Hits          650      655       +5     
- Misses        156      157       +1
Impacted Files Coverage Δ
lib/watermill.js 94.73% <85.71%> (-5.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3e1588...9fbcb32. Read the comment docs.

@thejmazz thejmazz merged commit 23ef9de into master Jul 7, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No new vulnerabilities
Details

@tiagofilipe12 tiagofilipe12 referenced this pull request Jul 7, 2017

Closed

Graph file #60

@tiagofilipe12 tiagofilipe12 deleted the logger_updated branch Jul 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment