Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added operation command to graphson #64

merged 3 commits into from Jul 12, 2017

Added operation command to graphson #64

merged 3 commits into from Jul 12, 2017


Copy link

@tiagofilipe12 tiagofilipe12 commented Jul 11, 2017

This PR adds operationString to task reducer and subsequently to graphson file and visualization. If it is a string passed as command to shell it will be outputed to graphson, otherwise it will not be included and thus it will render undefined in visualization and will be absent from graphson.json. This behavior can be simplified but for now this is cool, I think.

@@ -82,6 +84,9 @@ const taskReducer = (state = {}, action) => {
return Object.assign({}, state, { status: 'POST_VALIDATION', validated: true })
return Object.assign({}, state, {operationString: action.operationString})
Copy link

@thejmazz thejmazz Jul 12, 2017

spaces around { operationString: action.operationString }

@thejmazz thejmazz merged commit 6cc3300 into dev Jul 12, 2017
6 of 8 checks passed
@bmpvieira bmpvieira removed the ux label Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants