Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added operation command to graphson #64

Merged
merged 3 commits into from Jul 12, 2017

Conversation

3 participants
@tiagofilipe12
Copy link
Member

tiagofilipe12 commented Jul 11, 2017

This PR adds operationString to task reducer and subsequently to graphson file and visualization. If it is a string passed as command to shell it will be outputed to graphson, otherwise it will not be included and thus it will render undefined in visualization and will be absent from graphson.json. This behavior can be simplified but for now this is cool, I think.

@tiagofilipe12 tiagofilipe12 self-assigned this Jul 11, 2017

@tiagofilipe12 tiagofilipe12 requested a review from thejmazz Jul 11, 2017

@@ -82,6 +84,9 @@ const taskReducer = (state = {}, action) => {
case SUCCESS_VALIDATING_OUTPUT:
return Object.assign({}, state, { status: 'POST_VALIDATION', validated: true })
break
case SET_OPERATION_STRING:
return Object.assign({}, state, {operationString: action.operationString})

This comment has been minimized.

@thejmazz

thejmazz Jul 12, 2017

Member

spaces around { operationString: action.operationString }

@thejmazz thejmazz merged commit 6cc3300 into dev Jul 12, 2017

6 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/gitbook/epub GitBook build "epub" succeeded
Details
continuous-integration/gitbook/json GitBook build "json" succeeded
Details
continuous-integration/gitbook/mobi GitBook build "mobi" succeeded
Details
continuous-integration/gitbook/pdf GitBook build "pdf" succeeded
Details
continuous-integration/gitbook/website GitBook build "website" succeeded
Details
security/snyk No new vulnerabilities
Details

@bmpvieira bmpvieira removed the ux label Aug 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.