New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edits to two-mappers pipeline and removed of redundant defaultTask #67

Merged
merged 2 commits into from Jul 20, 2017

Conversation

2 participants
@tiagofilipe12
Member

tiagofilipe12 commented Jul 20, 2017

In this PR I made some changes to two-mappers example pipelines in order to avoid the usage of shell pipe, since for reproducibility isolating tasks would be better.
Also, defaultTask state was removed from lib/reducers/task.js since it is duplicated in lib/constants/default-task-state.js and was replaced by an import from the latter.

@tiagofilipe12 tiagofilipe12 self-assigned this Jul 20, 2017

@tiagofilipe12 tiagofilipe12 requested a review from thejmazz Jul 20, 2017

@thejmazz

lgtm. I think we should move reducer state defaults to be with the reducer as per Ducks style, but for now this is good to remove code duplication and other reorganization can happen after. I think the reason I moved it to another file was b/c some keys are more objects with their own default. (which even maybe, could be their own reducer..)

@thejmazz thejmazz merged commit d9813d2 into dev Jul 20, 2017

6 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/gitbook/epub GitBook build "epub" succeeded
Details
continuous-integration/gitbook/json GitBook build "json" succeeded
Details
continuous-integration/gitbook/mobi GitBook build "mobi" succeeded
Details
continuous-integration/gitbook/pdf GitBook build "pdf" succeeded
Details
continuous-integration/gitbook/website GitBook build "website" succeeded
Details
security/snyk No new vulnerabilities
Details

@bmpvieira bmpvieira deleted the viz branch Jul 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment