edits to two-mappers pipeline and removed of redundant defaultTask #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejmazz
approved these changes
Jul 20, 2017
Member
thejmazz
left a comment
thejmazz
left a comment
There was a problem hiding this comment.
lgtm. I think we should move reducer state defaults to be with the reducer as per Ducks style, but for now this is good to remove code duplication and other reorganization can happen after. I think the reason I moved it to another file was b/c some keys are more objects with their own default. (which even maybe, could be their own reducer..)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I made some changes to two-mappers example pipelines in order to avoid the usage of shell pipe, since for reproducibility isolating tasks would be better.
Also,
defaultTaskstate was removed fromlib/reducers/task.jssince it is duplicated inlib/constants/default-task-state.jsand was replaced by an import from the latter.