Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add another test for fork within fork wrapped in join #73
This PR fixes an issue with fork inside fork. Avoids the duplication of outermost tasks when fork is not nested in a join inside a fork. Previously this was not being properly handled because there was no way to check whether outermost tasks where the same as downstream tasks.
The rational is when fork is inside fork without join wrapping, outermost tasks will be the same as downstream tasks and thus should not be added to
To achieve the comparison of these two arrays (
Then was just a matter of checking if both hashes are equal or not.
@@ Coverage Diff @@ ## dev #73 +/- ## ========================================== + Coverage 81.83% 82.27% +0.43% ========================================== Files 37 37 Lines 881 897 +16 Branches 107 108 +1 ========================================== + Hits 721 738 +17 + Misses 160 159 -1
Tests for junction inside fork and fork inside fork (either wrapped in join or not) were added to check the shape of graph. This was performed by counting the length of the graphson array for vertices and for edges. I am aware that this is far from ideal but it is a quick way to check if something is broken in the near future. These tests must be re-worked after refactoring the pipeline object to something that can be run before execution.