New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change on the behavior of d3 visualization #86

Merged
merged 3 commits into from Aug 29, 2017

Conversation

3 participants
@tiagofilipe12
Member

tiagofilipe12 commented Aug 29, 2017

I have passed an environmental variable for d3 visualization tool to be triggered. Now it is only started when we pass the D3_LOGGER environmental variable to the shell before running the script. Also, I added these changes to the docs.

@tiagofilipe12 tiagofilipe12 self-assigned this Aug 29, 2017

@tiagofilipe12 tiagofilipe12 requested a review from thejmazz Aug 29, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Aug 29, 2017

Codecov Report

Merging #86 into master will decrease coverage by 0.31%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
- Coverage   82.09%   81.78%   -0.32%     
==========================================
  Files          37       37              
  Lines         905      906       +1     
  Branches      110      111       +1     
==========================================
- Hits          743      741       -2     
- Misses        162      165       +3
Impacted Files Coverage Δ
lib/reducers/collection.js 84.61% <60%> (-3.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31632eb...cca57d2. Read the comment docs.

@thejmazz thejmazz merged commit 4649996 into master Aug 29, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No new vulnerabilities
Details
@thejmazz

This comment has been minimized.

Member

thejmazz commented Aug 29, 2017

@tiagofilipe12 delete branch if its not needed

@tiagofilipe12 tiagofilipe12 deleted the viz_improvement branch Aug 29, 2017

@bmpvieira bmpvieira added this to Backlog in Bionode Project Board Sep 12, 2017

@bmpvieira bmpvieira moved this from Backlog to Done in Bionode Project Board Sep 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment