Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please make it AMD compliant. #1

Closed
yeban opened this Issue Jan 28, 2014 · 2 comments

Comments

2 participants
@yeban
Copy link
Member

yeban commented Jan 28, 2014

Afra uses RequireJS to load scripts.

@bmpvieira

This comment has been minimized.

Copy link
Member

bmpvieira commented Jan 28, 2014

Can you try converting it to AMD with anodynos/uRequire and see if it works? I could add boilerplate code to make it compatible with CommonJS and AMD but then would later have issues if I need to add dependencies. I rather prefer to stick to CommonJS and use converters. If it works I can then add the command to package.json in npm scripts to have something like npm run build-amd.

npm install urequire -g
cd bionode
urequire AMD . -f
@yeban

This comment has been minimized.

Copy link
Member Author

yeban commented Jan 28, 2014

urequire AMD . -f works for me. I ran it in lib/.

@bmpvieira bmpvieira closed this May 23, 2014

@bmpvieira bmpvieira added the question label Apr 4, 2017

@bmpvieira bmpvieira self-assigned this Apr 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.