Fixes test for running code coverage #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently COVERAGE gets set even if not defined as `COVERAGE=1` in the build environment.
|
It does get set to something other than zero at some point, but all values other than zero indicate that we are running code coverage (e.g., if COVERAGE=coveralls). [ -z "$COVERAGE" ] && export COVERAGE=0
[ "$COVERAGE" == "1" ] && export COVERAGE=coveralls # drop this eventually |
zmughal
reviewed
Aug 13, 2017
travis_scripts/trigger-dockerhub.sh
Outdated
| @@ -25,7 +25,7 @@ if [[ -z "$DOCKERHUB_TOKEN" ]] ; then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| if [[ -n "$COVERAGE" ]] ; then | |||
| if [[ -n "$COVERAGE" && $COVERAGE -ne 0 ]] ; then | |||
There was a problem hiding this comment.
This condition matches the one here:
if [ -n "$COVERAGE" ] && [ "$COVERAGE" != "0" ]; thenso this should be correct. It might be better to use the string comparison (!=) rather than the integer one (-ne).
There was a problem hiding this comment.
So by default it gets set to 0, and if $COVERAGE is already set to 1, it gets changed to "coveralls".
This means the test should be good, but I'm happy to change that to a string comparison, it shouldn't make any difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently COVERAGE gets set (to a non-empty value) even if not defined as
COVERAGE=1in the build environment.I don't know where the underlying script (
coverage-setup) is to verify, but I hope it doesn't get set to something other than0. @zmughal can you check?