Updated "new Class" to "Class->new()" per Perl Best Practices. #53

Merged
merged 2 commits into from Mar 12, 2013

Conversation

Projects
None yet
2 participants
Contributor

bvaisvil commented Mar 11, 2013

Hello All -

This is my first Pull request ever on git hub, so please let me know if there's anything else I should do along with this request.

I ran through the Bioperl modules replacing the "new Class" indirect object invocations to "Class->new()". Indirect object invocation can lead to subtle errors. (As per http://www.bioperl.org/wiki/Bioperl_Best_Practices and 'Modern Perl').

Regards,

Benjamin

bvaisvil added some commits Mar 11, 2013

@bvaisvil bvaisvil Per: http://www.bioperl.org/wiki/Bioperl_Best_Practices and
http://modernperlbooks.com/books/modern_perl/chapter_11.html, "new Class"
is to avoided. "Class->new()" should be used instead because bareword
indirect invocations can lead to subtle errors
f2260d6
@bvaisvil bvaisvil typo, removed -> e3a770c

@carandraug carandraug added a commit that referenced this pull request Mar 12, 2013

@carandraug carandraug Merge pull request #53 from bvaisvil/master
replace "new Class" with "Class->new()" per Perl Best Practices.
2f35aff

@carandraug carandraug merged commit 2f35aff into bioperl:master Mar 12, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment