Folder "images" #25

Open
MarkusPiotrowski opened this Issue Apr 16, 2016 · 12 comments

Projects

None yet

3 participants

@MarkusPiotrowski
Contributor

Since we may add some more image files (e.g. transparent Biopython logo, Twitter logo, Github logo....) we should think about putting them together in a folder "images" to keep the root clean.

@peterjc
Member
peterjc commented Apr 24, 2016

How about using /static/css/ and /static/images/ etc where the static folder is intended for website assets?

The Hyde theme uses /public/css/ etc for this https://github.com/poole/hyde/tree/master/public but I find the folder name less obvious.

@MarkusPiotrowski
Contributor

HTML5 Up! uses in their designs a folder assets as parent folder for css, fonts etc. which seems even more obvious than static?

@peterjc
Member
peterjc commented Apr 24, 2016

I like assets too :)

@mgudapak
Contributor

I can work on setting this up in _config.yml file - I believe that is where you define directory locations for various assets .. let me know if you folks would like me to work on this based on above approach

@peterjc peterjc added a commit that referenced this issue May 22, 2016
@peterjc peterjc Move css/*.css to assets/css/*.css
See discussion on #25 for reorganising the site assets
like css and images.
5aea6da
@peterjc
Member
peterjc commented May 22, 2016

@mgudapak if there's a standard approach using settings in _config.yml then sure, let's do that.

@mgudapak
Contributor
mgudapak commented May 22, 2016 edited

for the record .. these are the IMAGES we currently have

<repo_root_dir> $ find . -iname "*.png" -o -iname "*.jpg"
./apple-touch-icon-144.png
./biopython_grey.png
./wiki/Biopython.jpg
./wiki/Biopython_small.jpg
./wiki/Contig_class.png
./wiki/Hmm_discrete.png
./wiki/Hmm_discrete_py.png
./wiki/Journal.pcbi.1000406.g002.png
./wiki/Phylo-apaf-node0.png
./wiki/Phylo-apaf.png
./wiki/Phylo-draw-apaf1.png
./wiki/Smcra.png
./wiki/Torus_dbn.png
./wiki/TorusDBN.png
./wiki/Wininst.png
@peterjc
Member
peterjc commented May 22, 2016

All the images under wiki/ are not assets which are only part of the site layout, but rather part of the contents (originally being uploaded via MediaWiki). Here we do want to preserve the current URL.

Are there any constraints on site icons being at the top level like favicons?

@mgudapak
Contributor

for the record .. these are the CSS files we currently have

<repo_root_dir> $ find . -iname "*.css"
./css/hyde.css
./css/poole.css
./css/syntax.css
@mgudapak
Contributor
mgudapak commented May 22, 2016 edited

@peterjc - got it - i now see the difference between the ones under root to those under 'wiki'. So the goal is to relocate those under root to assets/images, and the css under ./css to assets/css.

Did I get it right?

and i will check on the favicons restrictions if any ..

@peterjc
Member
peterjc commented May 22, 2016

5aea6da - CSS moved.

ed473aa - grey background logo moved.

Favicons etc - can we move them?

Currently all these paths are hard coded in _include/*.html so if there's a conventional way to do this via _config.yml that would be better (which I think is what @mgudapak was suggesting).

@MarkusPiotrowski
Contributor

We don't have a real favicon, 'just' the apple-touch-icon. That works on Android mobiles as icon (when you put a bookmark on the home screen), (and, as I would suggest from the name, on Apple devices), but not as icon in Windows browsers on tabs and as bookmark. Don't now for Linus/Unix browsers. Thus, creating a nice favicon (16*16px!) is maybe another issue, we should raise separately. The actual Biopython logo with it's banner-like dimension is not applicable for downsizing to 16x16px.

@peterjc
Member
peterjc commented May 22, 2016

I've opened #86 for making a favicon (there is commented out code to use this in the Hyde/Poole template) 16x16 pixels will be a challenge.

https://mathiasbynens.be/notes/touch-icons suggests that the apple-touch-icon might be best left at the top level (root folder), but I've not confirmed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment