Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Hack for calling subprocess on Windows 8.1

Thanks to Ben Fulton for testing this, problem found by
test_Applicaion.py failing to call the echo command.
commit 780c2459cd1e76cb0a1a030de8b4cdec6dcef7b4 1 parent 2d2488c
@peterjc peterjc authored
Showing with 3 additions and 4 deletions.
  1. +3 −4 Bio/Application/__init__.py
View
7 Bio/Application/__init__.py
@@ -479,14 +479,13 @@ def __call__(self, stdin=None, stdout=True, stderr=True,
# Using universal newlines is important on Python 3, this
# gives unicode handles rather than bytes handles.
- # Windows 7 and 8 want shell = True
- # platform is easier to understand that sys to determine
- # windows version
+ # Windows 7, 8 and 8.1 want shell = True
+ # TODO: Test under Windows 10 and revisit platform detection.
if sys.platform != "win32":
use_shell = True
else:
win_ver = platform.win32_ver()[0]
- if win_ver in ["7", "8"]:
+ if win_ver in ["7", "8", "post2012Server"]:
use_shell = True
else:
use_shell = False
Please sign in to comment.
Something went wrong with that request. Please try again.