Minor refactoring #93

Open
wants to merge 16 commits into
from

2 participants

@yb66

Hi,

I do most of my work on topic branches and then merge that into a development branch, leaving master as the release candidate branch, hence why the last commit is to add develop to Travis-CI (for my convenience). It's a pretty standard Git workflow nowadays, and shouldn't affect anything until you add a develop branch (which I would advocate) but feel free to skip that commit if it doesn't suit you.

The other commits are just a little bit of clean up in the code, nothing drastic.

Regards,
Iain

@yb66

I'm continuing with refactoring the internals, so this pull will become less minor with time :) Cherry pick what you want, but I'll only push to this branch was passes the tests.

Regards,
Iain

@ngoto
bioruby member

Some commits are merged.

"Refactored to shorten, remove rescues, and clarify" is committed as 08dd928
"Fixed the stack level too deep errors by using Hash#invert" is committed as c229a20
"Early return clearer and idiomatic" is committed as 5f3569f

@ngoto
bioruby member

"Corrected spelling" is committed as 888a705

@ngoto ngoto added a commit that referenced this pull request Nov 14, 2014
@ngoto ngoto fix typo
 * fix typo. Thanks to Iain Barnett who reported the bug in
   #93
   (c4843d6)
888a705
@ngoto
bioruby member

Some commits are not merged.

Using absolute file path to require file is not a solution of circular require. Circular require can occur even if absolute file path is used.

@yb66

Hi @ngoto

It's been a while since I did those commits, but from looking at it, I'm not trying to solve the circular require by using absolute paths but by moving where the requires are called. The absolute paths is because I really wanted to use require_relative but Ruby v1.8 is still being supported which doesn't have them, so using the absolute path is the nearest thing without bringing in a gem or some extra code to handle it.

Hope that clears it up.

Regards,
Iain

@ngoto
bioruby member

@yb66 Thank you for explanation. BioRuby 1.5 will be the final version to support Ruby 1.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment