Docs: post-PR #53 status + frontend wire-up reality on main#54
Merged
Conversation
…up status After PR #48 → #53 landed, three docs were drifting and now name what's true on main: - docs/workflows-architecture.md "Open items" leads with the frontend listing wire-up status: backend `POST /simulations/runs` is live but frontend/app/pages/simulations/index.vue on main still renders mock data. Harrison's partial wire-up lives on remote branch origin/feature/runs-page, 18 commits behind main, with a known response-shape bug (assigns the whole `{ runs, pagination }` response to a `SimulationRun[]`-typed ref). - docs/simulation-runs-api-plan.md status banner now describes the full PR #48-#53 convergence as complete, the frontend follow-up as in-progress on a separate branch with the same known bug, and links to the architecture doc / memory for the coordination decision. - frontend/CLAUDE.md's Backend API Integration table row for index.vue was "GET /runs (currently commented out)" -- wrong path, wrong method, wrong state. Now lists `POST /simulations/runs` with the actual state ("not wired on main; partial wire-up on origin/feature/runs-page; see api-plan doc"). A new memory `project_frontend_runs_branch` and an updated `project_simulations_endpoint` carry the same state across sessions for context-loading. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Five stale spots in docs/workflows-architecture.md surfaced by an audit: 1. Shape B heading said "(open)" for PR #51 — it merged ages ago. 2. Shape C diagram label on the status-endpoint edges still showed only the hybrid read; PR #53 added the DB-only fallback when the workflow query fails (and only 404s when both sources are empty). 3. Shape C diagram's POLL -> DB_SIMS arrow showed an unconditional "write result"; PR #53 (#5 fix) made it SUCCEEDED-only. 4. Sequence diagram had the same two omissions: - POLL -> DBS write now in an alt/else (SUCCEEDED inserts, FAILED / RUN_ID_NOT_FOUND skips). - "loop polling" status read now in an alt/else with the workflow- query happy path AND the DB-fallback path (with its own records-vs-404 inner alt). 5. Storage-layer prose called BiosimSims "one per unique computation" without noting SUCCEEDED-only since PR #53. Pure label/annotation updates; no structural workflow change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Mermaid's sequence-diagram parser treats # as a control character in alt/else labels, so '(since PR #53)' broke parsing on two lines. Reworded those two labels (the prose around the diagram still says PR #53 explicitly). Flowchart edge labels in quoted strings parse fine, so the two PR #53 mentions in the Shape C flowchart stay. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc-only follow-up after the PR #48–#53 stack landed. Three docs were drifting and now name what's actually true on `main`.
What changed
`docs/workflows-architecture.md` "Open items" leads with the frontend listing wire-up status:
`docs/simulation-runs-api-plan.md` status banner now describes the full convergence (PR Add POST /simulations/runs listing endpoint + convergence plan #48–Cleanup: four high-severity findings from PR #52 review #53) as backend-complete, the frontend follow-up as partial-on-a-separate-branch with the same known bug, and points readers to the architecture doc / memory for the coordination decision.
`frontend/CLAUDE.md` "Backend API Integration" table row for `index.vue` was stale (`GET /runs (currently commented out)` — wrong path, wrong method, wrong state). Now lists `POST /simulations/runs` with the actual state.
Out of scope (intentionally)
This is a status-truth-up update, not a content-shift. The PR3 plan, the biosim-client TODO, the known-issues catalog from the PR #52 review, and the worker-drain deploy callout (all already in `docs/`) are unchanged.
Not in this PR
Two memory files were updated in parallel (`~/.claude/projects/.../memory/project_simulations_endpoint.md` rewritten for post-#53 state; new `project_frontend_runs_branch.md`) — those live on Jim's machine, not in the repo.
🤖 Generated with Claude Code