Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Use prettier for fixing #16

Closed
jurekbarth opened this Issue Mar 1, 2019 · 3 comments

Comments

Projects
None yet
4 participants
@jurekbarth
Copy link
Member

commented Mar 1, 2019

Right now eslint:fix fixes by far not everything that i would suspect to be fixable automagically.

Prettier (https://prettier.io/) uses a different approach by rewriting the whole code, based on the ruleset i.e. eslint rules. Therefor a lot of stuff will be fixed. We use it in biotope-build and it enhanced the code style and rules, better than eslint alone before.

@timomayer

This comment has been minimized.

Copy link
Member

commented Mar 1, 2019

vote for prettier 👍
but please keep in mind that code optimization should only run when quality gate is running on a devs local maschine BEFORE a commit.
it should not run on a jenkins server during our normal build process. there only "checks" should run, no optimizations.

@tiagomapmarques

This comment has been minimized.

Copy link
Member

commented Mar 1, 2019

@timomayer We have that covered. From the docs:
screen shot 2019-03-01 at 14 46 59

@jurekbarth Will investigate. Probably even fixes #17 :)

@ctmm

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2019

@jurekbarth

While working on #17 I considered to use prettier for code formatting instead of eslint.

I tested that option and, although it is possible, we decided not to pursue that route as it would require a lengthy refactor of the project.

That being said, I ask you to consider closing this issue as we do not currently have the resources to integrate prettier and the fix on #17 already adds eslint's autofixing.

Looking forward for your input!

@jurekbarth jurekbarth closed this Apr 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.