Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Change package manager to npm #20

Closed
jurekbarth opened this issue Dec 5, 2018 · 7 comments
Closed

RFC: Change package manager to npm #20

jurekbarth opened this issue Dec 5, 2018 · 7 comments

Comments

@jurekbarth
Copy link
Contributor

I would like to propose the change from yarn to npm package manager.

I would like to do so, because of npm audit and because it feels more "native".

What do you think about it?

@SheepFromHeaven
Copy link
Member

SheepFromHeaven commented Dec 5, 2018 via email

@timomayer
Copy link
Member

why remove it? we should keep commiting lock files to have reproducable behaviours, in our projects.
I like yarn more, but it is ok for me to switch back to npm feature wise it makes no difference we did the move to yarn before npm had the lock file feature

@SheepFromHeaven
Copy link
Member

@timomayer the problem is, that we need to update the yarn.lock file manually after each install of automatically before every push. This takes quite a time. In addition to that we should enforce NPM because of the audit feature. So we make sure no malicious packages get installed.

@timomayer
Copy link
Member

@SheepFromHeaven ok the audit feature is a reason to switch back, i agree.

@timomayer
Copy link
Member

@dannystey maybe you can look into that as well when you are doing the 2 bugfixes?

@dannystey
Copy link

@SheepFromHeaven @timomayer the audit feature isnt a reason to switch back anymore, as yarn has the audit feature since 1.12.0, but i would also prefer that the developer has the chance to decide if he/she likes to use yarn or npm. yarn imports the package-json.lock since version 1.7.0, so there is no need to have a yarn.lock in the repository.

@timomayer timomayer added this to the 3.0 milestone Apr 1, 2020
@timomayer
Copy link
Member

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants