From 93e099e409ad064427ef95aa7f42005f954dd48b Mon Sep 17 00:00:00 2001 From: Nishanth Vijayan Date: Sun, 31 Mar 2019 15:24:38 +0530 Subject: [PATCH] Remove dead code found flag is a remnant from the time when ls command used to take a group name as argument. However, group ls does not take any arguments now --- cmd/kaf/group.go | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/cmd/kaf/group.go b/cmd/kaf/group.go index 111dcb9a..3b67e0f1 100644 --- a/cmd/kaf/group.go +++ b/cmd/kaf/group.go @@ -52,7 +52,7 @@ var groupsCmd = &cobra.Command{ var groupLsCmd = &cobra.Command{ Use: "ls", Short: "List groups", - Args: cobra.MaximumNArgs(1), + Args: cobra.NoArgs, Run: func(cmd *cobra.Command, args []string) { admin, err := getClusterAdmin() if err != nil { @@ -79,8 +79,6 @@ var groupLsCmd = &cobra.Command{ fmt.Fprintf(w, "NAME\tSTATE\tCONSUMERS\t\n") } - found := false - groupDescs, err := admin.DescribeConsumerGroups(groupList) if err != nil { panic(err) @@ -92,10 +90,10 @@ var groupLsCmd = &cobra.Command{ fmt.Fprintf(w, "%v\t%v\t%v\t\n", detail.GroupId, state, consumers) } - if found || len(args) == 0 { + if len(groupDescs) != 0 { w.Flush() } else { - fmt.Printf("Group %v not found\n", args[0]) + fmt.Printf("No Groups found\n") } return